This repository was archived by the owner on Oct 27, 2020. It is now read-only.
fix(index): this of stat method is undefined
#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
whxaxes
changed the title
Closed
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 17.14% 17.14%
=======================================
Files 2 2
Lines 105 105
Branches 15 15
=======================================
Hits 18 18
Misses 73 73
Partials 14 14
Continue to review full report at Codecov.
|
|
@whxaxes Please accept CLA |
|
@evilebottnawi done |
michael-ciniawsky
changed the title
this of stat method is undefined
michael-ciniawsky
approved these changes
Oct 31, 2018
src/index.js
Outdated
| @@ -41,9 +41,9 @@ function loader(...args) { | |||
| // this.fs can be undefined | |||
| // e.g when using the thread-loader | |||
| // fallback to the fs module | |||
| const stat = this.fs ? this.fs.stat : fs.stat; | |||
| const tempFs = this.fs || fs; | |||
There was a problem hiding this comment.
Suggested change
| const tempFs = this.fs || fs; | |
| const FS = this.fs || fs; |
There was a problem hiding this comment.
@michael-ciniawsky FS? Why in uppercase? Why not usingFs or something related?
src/index.js
Outdated
| const toDepDetails = (dep, mapCallback) => { | ||
| stat(dep, (err, stats) => { | ||
| tempFs.stat(dep, (err, stats) => { |
There was a problem hiding this comment.
Suggested change
| tempFs.stat(dep, (err, stats) => { | |
| FS.stat(dep, (err, stats) => { |
src/index.js
Outdated
| @@ -112,9 +112,9 @@ function pitch(remainingRequest, prevRequest, dataInput) { | |||
| callback(); | |||
| return; | |||
| } | |||
| const stat = this.fs ? this.fs.stat : fs.stat; | |||
| const tempFs = this.fs || fs; | |||
There was a problem hiding this comment.
Suggested change
| const tempFs = this.fs || fs; | |
| const FS = this.fs || fs; |
src/index.js
Outdated
| async.each(cacheData.dependencies.concat(cacheData.contextDependencies), (dep, eachCallback) => { | ||
| stat(dep.path, (statErr, stats) => { | ||
| tempFs.stat(dep.path, (statErr, stats) => { |
There was a problem hiding this comment.
Suggested change
| tempFs.stat(dep.path, (statErr, stats) => { | |
| FS.stat(dep.path, (statErr, stats) => { |
|
@michael-ciniawsky done |
michael-ciniawsky
approved these changes
Oct 31, 2018
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed this issue: #46